Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for detecting reliable stack traces

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for detecting reliable stack traces
Date	Fri, 08 Apr 2016 10:30:02 +0200
Message-ID	<rlzXI-XP-17@gated-at.bofh.it> (permalink)
References	<rgFKp-6zA-3@gated-at.bofh.it> <rgFKr-6zA-59@gated-at.bofh.it> <rlgLo-3f5-1@gated-at.bofh.it> <rljpV-5mp-35@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Kosina <jikos@kernel.org>, Jessica Yu <jeyu@redhat.com>, Miroslav Benes <mbenes@suse.cz>, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik <vojtech@suse.com>
X-Original-Date	Fri, 8 Apr 2016 10:24:15 +0200
X-Original-Message-ID	<20160408082415.GG5218@pathway.suse.cz>
X-Original-References	<cover.1458933243.git.jpoimboe@redhat.com> <1f8c648ed8b8eb49a75f5a6cacf8b7ca76f44fa9.1458933243.git.jpoimboe@redhat.com> <20160407115552.GB27670@pathway.suse.cz> <20160407144655.kf7ujfctdlvnwx6s@treble.redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1374076

Show key headers only | View raw

On Thu 2016-04-07 09:46:55, Josh Poimboeuf wrote:
> On Thu, Apr 07, 2016 at 01:55:52PM +0200, Petr Mladek wrote:
> > Well, I wonder if we should be more suspicious and make
> > sure that only the regular process stack is used.
> 
> Notice the save_stack_stack_reliable() function, which is called by
> dump_trace() when the task is running on an interrupt or exception
> stack.  It returns -EINVAL, so the stack gets marked unreliable.  Does
> that address your concern, or did you mean something else?

I see. It does what I wanted.

Thanks,
Petr

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for  detecting reliable stack traces Petr Mladek <pmladek@suse.com> - 2016-04-07 14:00 +0200
  Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for  detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-07 16:50 +0200
    Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for  detecting reliable stack traces Petr Mladek <pmladek@suse.com> - 2016-04-08 10:30 +0200

csiph-web