Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373831

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

Show all headers | View raw

On 04/03, Neil Armstrong wrote:
> On 04/02/2016 02:50 AM, Stephen Boyd wrote:
> > On 04/01, Neil Armstrong wrote:
> >> +	if (!onecell_data)
> >> +		return -ENOMEM;
> >> +
> >> +	regmap = syscon_node_to_regmap(of_get_parent(np));
> > 
> > Can we use dev_get_regmap(&pdev->dev.parent) here instead? I'd
> > prefer device APIs over DT APIs here. 
> > 
> 
> It will not work here since the parent node is a syscon, the call to syscon_node_to_regmap() will call of_syscon_register() and create the regmap, the dev_get_regmap() needs a proper platform device registered as regmap here.
> 

Ok. I was hoping that we could make simple-mfd look to see if
there's a syscon and then attach it to the parent device, but it
seems that simple-mfd is not actually a driver and it might not
even make a parent device for the children nodes?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks Neil Armstrong <narmstrong@baylibre.com> - 2016-04-03 16:00 +0200
  Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-04-08 01:40 +0200
    Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks Neil Armstrong <narmstrong@baylibre.com> - 2016-04-11 16:10 +0200
      Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-04-12 00:10 +0200

csiph-web