Re: [PATCH] livepatch: robustify klp_register_patch() API error checking

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] livepatch: robustify klp_register_patch() API error checking
Date	2016-04-07 22:40 +0200
Message-ID	<rloSC-YH-23@gated-at.bofh.it> (permalink)
References	<rlkFl-6uI-31@gated-at.bofh.it> <rlkFl-6uI-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 7 Apr 2016, Jiri Kosina wrote:

> From: Jiri Kosina <jkosina@suse.cz>
> 
> Commit 425595a7fc20 ("livepatch: reuse module loader code to write 
> relocations") adds a possibility of dereferncing pointers supplied by the 
> consumer of the livepatch API before sanity (NULL) checking them (patch 
> and patch->mod).
> 
> Spotted by smatch tool.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Jessica Yu <jeyu@redhat.com>

Pushed out. Thanks,	

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] livepatch: robustify klp_register_patch() API error  checking Jiri Kosina <jikos@kernel.org> - 2016-04-07 18:10 +0200
  Re: [PATCH] livepatch: robustify klp_register_patch() API error  checking Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-07 20:10 +0200
  Re: livepatch: robustify klp_register_patch() API error checking Jessica Yu <jeyu@redhat.com> - 2016-04-07 20:30 +0200
  Re: [PATCH] livepatch: robustify klp_register_patch() API error  checking Jiri Kosina <jikos@kernel.org> - 2016-04-07 22:40 +0200

csiph-web