Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373723

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Show all headers | View raw

On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
> > > Joe Perches <joe@perches.com> wrote:
> > > > It might be better to remove kenter and _enter
> > > > altogether and use function tracing instead.
> > > Possibly - but not at this time.
> > Swell.
> I didn't say I wouldn't do it - it's just that I'm trying to fix other stuff
> at the moment and don't particularly want to add that to the list just now.
> kenter, _enter and co. are serving me very well.

No worries, I didn't mean to imply you wouldn't.
It's your code, do what and when you want.

> > > Besides, isn't the function tracing log lost
> > > if the machine crashes?
> > I believe yes, but would it matter?
> Let's see...  If the machine panics whilst I'm developing stuff (quite likely
> if something goes wrong in BH context), how do I get at the function tracing
> log to find out why it panicked if the log is then lost?  With the serial
> console, at least I automatically capture the output of kenter and co..

But you also don't get a bunch of other useful stuff.

btw: there is ftrace_dump_on_oops

https://lwn.net/Articles/366796/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  [PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling  functions David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  [PATCH 2/9] rxrpc: Disable a debugging statement that has been left  enabled. David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
    Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. Joe Perches <joe@perches.com> - 2016-04-07 18:40 +0200
      Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 19:10 +0200
        Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. Joe Perches <joe@perches.com> - 2016-04-07 19:20 +0200
          Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 21:50 +0200
            Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. Joe Perches <joe@perches.com> - 2016-04-07 22:30 +0200
              Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 22:50 +0200
      Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. David Miller <davem@davemloft.net> - 2016-04-07 19:40 +0200
        Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 21:50 +0200
          Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. David Miller <davem@davemloft.net> - 2016-04-07 22:40 +0200
            Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 22:50 +0200
              Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been  left enabled. David Miller <davem@davemloft.net> - 2016-04-07 23:00 +0200
                Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. David Howells <dhowells@redhat.com> - 2016-04-07 23:30 +0200
  [PATCH 4/9] rxrpc: Static arrays of strings should be const char  *const[] David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  [PATCH 5/9] rxrpc: Differentiate local and remote abort codes in  structs David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  [PATCH 1/9] afs: Wait for outstanding async calls before closing  rxrpc socket David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  [PATCH 9/9] rxrpc: Create a null security type and get rid of  conditional calls David Howells <dhowells@redhat.com> - 2016-04-07 18:30 +0200
  Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Miller <davem@davemloft.net> - 2016-04-11 21:40 +0200
    Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells <dhowells@redhat.com> - 2016-04-11 22:40 +0200
    Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells <dhowells@redhat.com> - 2016-04-12 00:10 +0200
      Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells <dhowells@redhat.com> - 2016-04-12 00:40 +0200
      Re: [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Miller <davem@davemloft.net> - 2016-04-12 03:30 +0200

csiph-web