Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373613

Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs

Show all headers | View raw

* Grygorii Strashko <grygorii.strashko@ti.com> [160406 04:47]:
> Now wakeirq stops working for device if wakeup option for
> this device will be reconfigured through sysfs, like:
> 
> echo disabled > /sys/devices/platform/extcon_usb1/power/wakeup
> echo enabled > /sys/devices/platform/extcon_usb1/power/wakeup
> 
> Once above set of commands is executed the device's wakeup_source
> opject will be recreated and dev->power.wakeup->wakeirq field will
> contain NULL. As result, device_wakeup_arm_wake_irqs() will not arm
> wakeirq for the affected device.
> 
> Hece, lets try to fix it in the following way:
>   check for dev->wakeirq field when device_wakeup_attach() is called
>   and if !NULL re-attach wakeirq to the device

Yeah I think that's all there is to it, thanks for fixing it:

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-06 13:50 +0200
  Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup  re-configuration from sysfs Tony Lindgren <tony@atomide.com> - 2016-04-07 20:00 +0200
    Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-07 23:30 +0200

csiph-web