Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown
Date	2016-04-07 19:50 +0200
Message-ID	<rlme6-7wf-5@gated-at.bofh.it> (permalink)
References	<rabP4-r4-27@gated-at.bofh.it> <rabP4-r4-25@gated-at.bofh.it> <rlkFk-6uI-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/7/2016 12:06 PM, Bjorn Helgaas wrote:
>> __release_pci_root_info function if the region type is IO.
> I don't know what "removing a slot" means.  You're changing
> pci_root.c, so I assume this is really an ACPI host bridge removal?
> 

Correct, I'm removing the host bridge.

> The release should correspond to a mapping, and the changelog should
> point out where that mapping happens so we can see the symmetry.
> 

I apologize. This is based on Tomasz's v5 patch here.

https://github.com/semihalf-nowicki-tomasz/linux/blob/pci-acpi-v5/drivers/acpi/pci_root.c


> You say this is undoing the effect of pci_remap_iospace(), but that's
> only called by native drivers and the generic (OF) driver, not by
> pci_root.c.

See the ACPI root bridge driver above.

> 
> Please combine this with the previous patch so we have the new
> function and its use in the same patch.
> 

I can do that. I was trying to keep the reviews as small as possible.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Thread

Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Bjorn Helgaas <helgaas@kernel.org> - 2016-04-07 18:10 +0200
  Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Sinan Kaya <okaya@codeaurora.org> - 2016-04-07 19:50 +0200
    Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Bjorn Helgaas <helgaas@kernel.org> - 2016-04-07 23:50 +0200
      Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Sinan Kaya <okaya@codeaurora.org> - 2016-04-08 05:50 +0200
        Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Tomasz Nowicki <tn@semihalf.com> - 2016-04-08 09:00 +0200
          Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Sinan Kaya <okaya@codeaurora.org> - 2016-04-08 19:50 +0200
            Re: [PATCH 2/2] pci, acpi: free IO resource during shutdown Tomasz Nowicki <tn@semihalf.com> - 2016-04-09 10:50 +0200

csiph-web