Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373356

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

Show all headers | View raw

On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote:
> The driver's init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
> 
> Currently the macro is not being used because the driver is initialized at
> subsys init call level but this isn't necessary since consumer devices are
> defined in the DT as dependencies so there's no need for init calls order.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> This patch was tested on an Exynos5422 Odroid XU4 board.

This test might not be sufficient. XU4 is not a mobile device like many
other users of this driver (except Arndale Octa and Artiks all of other
users are mobiles/wearables).

For example XU4 does not have USB OTG (like other devices and like XU3).

Best regards,
Krzysztof

> 
>  drivers/regulator/s2mps11.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-06 16:00 +0200
  Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver()  instead subsys initcall Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-07 14:40 +0200
    Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver()  instead subsys initcall Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-07 20:20 +0200
      Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver()  instead subsys initcall Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-08 06:00 +0200

csiph-web