Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373111

Re: [PATCH 03/11] locking, rwsem: introduce basis for down_write_killable

From Davidlohr Bueso <dave@stgolabs.net>
Newsgroups linux.kernel
Subject Re: [PATCH 03/11] locking, rwsem: introduce basis for down_write_killable
Date 2016-04-07 09:00 +0200
Message-ID <rlc53-8lR-7@gated-at.bofh.it> (permalink)
References <rj57H-3qc-3@gated-at.bofh.it> <rj57H-3qc-1@gated-at.bofh.it> <rjlFw-6Uj-17@gated-at.bofh.it> <rk8PV-S8-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 04 Apr 2016, Michal Hocko wrote:

>Not sure I got your point here.

You set current to TASK_KILLABLE in the sleep loop, why do you want to change
it here to TASK_RUNNING if its about to be killed? At least in the case of
UNINTERRUPTABLE we do it merely as a redundancy after the breaking out of the
loop. Of course we also acquired the lock in the first place by that time and
we _better_ be running.

Thanks,
Davidlohr

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/11] locking, rwsem: introduce basis for  down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-04 11:20 +0200
  Re: [PATCH 03/11] locking, rwsem: introduce basis for  down_write_killable Peter Zijlstra <peterz@infradead.org> - 2016-04-04 11:30 +0200
  Re: [PATCH 03/11] locking, rwsem: introduce basis for  down_write_killable Davidlohr Bueso <dave@stgolabs.net> - 2016-04-07 09:00 +0200
    Re: [PATCH 03/11] locking, rwsem: introduce basis for  down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-07 09:40 +0200

csiph-web