Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374440

Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks

Show all headers | View raw

On Fri, 8 Apr 2016 15:15:42 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> From what I understand, the slowfn() modifies the task pi_list (or
> rbtree, as it is today). As this is an unlock, the task being woken
> (the next one to grab the lock) is removed from the previous task's pi
> list.
> 
> In rt_mutex_adjust_prio(current) I see it simply grabs current's
> pi_lock and calls __rt_mutex_adjust_prio(current). This calls
> rt_mutex_getprio(current) which returns current's normal prio if it
> doesn't have any pi waiters, or it looks at the top pi waiter on the
> tasks list and returns that. Which wouldn't be the task on wake_q,
> otherwise we wouldn't be deboosting in the first place.
> 

OK, I now see that the your previous patch is changing what I'm looking
at :-) This is what happens when you go away and try to catch up on
email and not read the emails by threads. I see the
rt_mutex_adjust_prio() is being changed.

I'll go back and look at your previous patch (as I looked at that while
traveling and didn't think too hard about it).

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-05 10:40 +0200
  Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-05 11:30 +0200
    Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-05 11:40 +0200
      Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-05 12:50 +0200
        Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-05 13:40 +0200
      Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline  tasks Steven Rostedt <rostedt@goodmis.org> - 2016-04-08 18:30 +0200
        Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-08 19:40 +0200
          Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-08 21:00 +0200
            Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline  tasks Steven Rostedt <rostedt@goodmis.org> - 2016-04-08 21:20 +0200
              Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline  tasks Steven Rostedt <rostedt@goodmis.org> - 2016-04-08 21:30 +0200
                Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-09 05:30 +0200
            Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-09 05:30 +0200
              Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-09 15:40 +0200
                Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-10 10:30 +0200
                Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-12 05:10 +0200
                Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Peter Zijlstra <peterz@infradead.org> - 2016-04-12 18:00 +0200
                Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Xunlei Pang <xpang@redhat.com> - 2016-04-13 04:20 +0200
          Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline  tasks Steven Rostedt <rostedt@goodmis.org> - 2016-04-08 21:00 +0200

csiph-web