Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1374393
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates |
| Date | 2016-04-08 19:50 +0200 |
| Message-ID | <rlIHD-7v9-3@gated-at.bofh.it> (permalink) |
| References | <rlt5T-4eY-1@gated-at.bofh.it> <rlt5T-4eY-7@gated-at.bofh.it> <rlC9b-2s3-13@gated-at.bofh.it> <rlEb2-3RN-63@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 08, 2016 at 02:55:22PM +0200, Frederic Weisbecker wrote:
> > > @@ -4540,17 +4568,8 @@ static void cpu_load_update(struct rq *this_rq, unsigned long this_load,
> > >
> > > /* scale is effectively 1 << i now, and >> i divides by scale */
> > >
> > > - old_load = this_rq->cpu_load[i];
> > #ifdef CONFIG_NO_HZ_COMMON
> > > - old_load = decay_load_missed(old_load, pending_updates - 1, i);
> > > - if (tickless_load) {
> > > - old_load -= decay_load_missed(tickless_load, pending_updates - 1, i);
> > > - /*
> > > - * old_load can never be a negative value because a
> > > - * decayed tickless_load cannot be greater than the
> > > - * original tickless_load.
> > > - */
> > > - old_load += tickless_load;
> > > - }
> > #endif
>
> Ah sure, if you prefer it that way, I can do that.
Yes please. I normally favour the thing you did, but here it makes
tricky code that much harder to read.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] sched: Fix/improve nohz cpu load updates v2 Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 03:10 +0200
[PATCH 2/3] sched: Correctly handle nohz ticks cpu load accounting Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 03:10 +0200
Re: [PATCH 2/3] sched: Correctly handle nohz ticks cpu load accounting Peter Zijlstra <peterz@infradead.org> - 2016-04-08 11:50 +0200
Re: [PATCH 2/3] sched: Correctly handle nohz ticks cpu load accounting Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 15:00 +0200
Re: [PATCH 2/3] sched: Correctly handle nohz ticks cpu load accounting Peter Zijlstra <peterz@infradead.org> - 2016-04-08 19:50 +0200
[PATCH 1/3] sched: Gather cpu load functions under a more conventional namespace Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 03:10 +0200
[PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 03:10 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Peter Zijlstra <peterz@infradead.org> - 2016-04-08 12:50 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-08 15:00 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Peter Zijlstra <peterz@infradead.org> - 2016-04-08 19:50 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-11 15:20 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-11 20:30 +0200
Re: [PATCH 3/3] sched: Optimize !CONFIG_NO_HZ_COMMON cpu load updates Peter Zijlstra <peterz@infradead.org> - 2016-04-12 16:30 +0200
csiph-web