Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1374396

Re: [PATCH v2 1/4] percpu_stats: Simple per-cpu statistics count helper functions

From kbuild test robot <lkp@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/4] percpu_stats: Simple per-cpu statistics count helper functions
Date 2016-04-08 19:50 +0200
Message-ID <rlIHD-7v9-11@gated-at.bofh.it> (permalink)
References <rlHiy-6xv-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi Waiman,

[auto build test ERROR on ext4/dev]
[also build test ERROR on v4.6-rc2 next-20160408]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Waiman-Long/ext4-Improve-parallel-I-O-performance-on-NVDIMM/20160409-002128
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: um-x86_64_defconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

Note: the linux-review/Waiman-Long/ext4-Improve-parallel-I-O-performance-on-NVDIMM/20160409-002128 HEAD 712a939b92b9178cb79df4050bba8e6b1d03ca63 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   In file included from arch/um/include/generated/asm/percpu.h:1:0,
                    from include/linux/percpu.h:12,
                    from include/linux/percpu_stats.h:7,
                    from lib/percpu_stats.c:5:
   include/linux/percpu_stats.h: In function 'percpu_stats_add':
>> include/asm-generic/percpu.h:120:2: error: implicit declaration of function 'raw_local_irq_save' [-Werror=implicit-function-declaration]
     raw_local_irq_save(__flags);     \
     ^
>> include/asm-generic/percpu.h:322:34: note: in expansion of macro 'this_cpu_generic_to_op'
    #define this_cpu_add_1(pcp, val) this_cpu_generic_to_op(pcp, val, +=)
                                     ^
>> include/linux/percpu-defs.h:364:11: note: in expansion of macro 'this_cpu_add_1'
      case 1: stem##1(variable, __VA_ARGS__);break;  \
              ^
   include/linux/percpu-defs.h:496:33: note: in expansion of macro '__pcpu_size_call'
    #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                    ^
>> include/linux/percpu_stats.h:29:2: note: in expansion of macro 'this_cpu_add'
     this_cpu_add(pcs->stats[stat], cnt);
     ^
>> include/asm-generic/percpu.h:122:2: error: implicit declaration of function 'raw_local_irq_restore' [-Werror=implicit-function-declaration]
     raw_local_irq_restore(__flags);     \
     ^
>> include/asm-generic/percpu.h:322:34: note: in expansion of macro 'this_cpu_generic_to_op'
    #define this_cpu_add_1(pcp, val) this_cpu_generic_to_op(pcp, val, +=)
                                     ^
>> include/linux/percpu-defs.h:364:11: note: in expansion of macro 'this_cpu_add_1'
      case 1: stem##1(variable, __VA_ARGS__);break;  \
              ^
   include/linux/percpu-defs.h:496:33: note: in expansion of macro '__pcpu_size_call'
    #define this_cpu_add(pcp, val)  __pcpu_size_call(this_cpu_add_, pcp, val)
                                    ^
>> include/linux/percpu_stats.h:29:2: note: in expansion of macro 'this_cpu_add'
     this_cpu_add(pcs->stats[stat], cnt);
     ^
   cc1: some warnings being treated as errors

vim +/raw_local_irq_save +120 include/asm-generic/percpu.h

eba117889a Tejun Heo 2014-06-17  114  	__ret;								\
9c28278a24 Tejun Heo 2014-06-17  115  })
9c28278a24 Tejun Heo 2014-06-17  116  
eba117889a Tejun Heo 2014-06-17  117  #define this_cpu_generic_to_op(pcp, val, op)				\
9c28278a24 Tejun Heo 2014-06-17  118  do {									\
eba117889a Tejun Heo 2014-06-17  119  	unsigned long __flags;						\
eba117889a Tejun Heo 2014-06-17 @120  	raw_local_irq_save(__flags);					\
9c28278a24 Tejun Heo 2014-06-17  121  	*raw_cpu_ptr(&(pcp)) op val;					\
eba117889a Tejun Heo 2014-06-17 @122  	raw_local_irq_restore(__flags);					\
9c28278a24 Tejun Heo 2014-06-17  123  } while (0)
9c28278a24 Tejun Heo 2014-06-17  124  
eba117889a Tejun Heo 2014-06-17  125  #define this_cpu_generic_add_return(pcp, val)				\

:::::: The code at line 120 was first introduced by commit
:::::: eba117889ac444bea6e8270049cbaeed48169889 percpu: preffity percpu header files

:::::: TO: Tejun Heo <tj@kernel.org>
:::::: CC: Tejun Heo <tj@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/4] ext4: Improve parallel I/O performance on NVDIMM Waiman Long <Waiman.Long@hpe.com> - 2016-04-08 18:20 +0200
  [PATCH v2 3/4] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin() called Waiman Long <Waiman.Long@hpe.com> - 2016-04-08 18:20 +0200
  [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit architectures Waiman Long <Waiman.Long@hpe.com> - 2016-04-08 18:20 +0200
    Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit  architectures Tejun Heo <tj@kernel.org> - 2016-04-08 18:50 +0200
      Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit architectures Waiman Long <waiman.long@hpe.com> - 2016-04-08 19:40 +0200
        Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit  architectures Tejun Heo <tj@kernel.org> - 2016-04-08 19:50 +0200
          Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit architectures Waiman Long <waiman.long@hpe.com> - 2016-04-08 20:50 +0200
            Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit  architectures Tejun Heo <tj@kernel.org> - 2016-04-12 00:20 +0200
              Re: [PATCH v2 2/4] percpu_stats: Enable 64-bit counts in 32-bit architectures Waiman Long <waiman.long@hpe.com> - 2016-04-12 20:20 +0200
  [PATCH v2 1/4] percpu_stats: Simple per-cpu statistics count helper functions Waiman Long <Waiman.Long@hpe.com> - 2016-04-08 18:20 +0200
    Re: [PATCH v2 1/4] percpu_stats: Simple per-cpu statistics count  helper functions kbuild test robot <lkp@intel.com> - 2016-04-08 18:50 +0200
    Re: [PATCH v2 1/4] percpu_stats: Simple per-cpu statistics count  helper functions kbuild test robot <lkp@intel.com> - 2016-04-08 19:50 +0200

csiph-web