Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374325

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

Show all headers | View raw

On 04/08/2016 12:06 PM, Jose Abreu wrote:
> Hi Mark,
> 
> 
> On 07-04-2016 18:53, Mark Brown wrote:
>> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote:
>>
>>> + Optional properties:
>>> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set
>>> +   it is required to use the properties 'dmas' and 'dma-names'.
>> This is not a good interface, it's describing Linux internal APIs.  If
>> the device needs to operate in PIO mode it should just do that.
> 
> I added this interface because there is no direct way to check if DMA is
> available on the I2S controller so it is not possible to automatically change
> between DMA and PIO mode. As the I2S controller can be built with or without DMA
> support it is necessary to somehow check if DMA is enabled or not and according
> to that use either ALSA DMA engine or the custom platform driver sent in these
> patches. I did not want to remove drivers functionality so I added this property
> to the DT. This way a user can select between DMA and PIO mode.

That's OK, but you need to describe the hardware, not the indented behavior
of the software driver.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-07 19:00 +0200
  [PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-07 19:00 +0200
  [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-07 19:00 +0200
    Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver Mark Brown <broonie@kernel.org> - 2016-04-07 20:00 +0200
      Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-08 12:10 +0200
        Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for  I2S Driver Lars-Peter Clausen <lars@metafoo.de> - 2016-04-08 18:00 +0200
          Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for  I2S Driver Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-08 18:10 +0200
            Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for  I2S Driver Lars-Peter Clausen <lars@metafoo.de> - 2016-04-09 17:00 +0200
              Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for  I2S Driver Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-11 11:30 +0200
  [PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-07 19:00 +0200
  [PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR Jose Abreu <Jose.Abreu@synopsys.com> - 2016-04-07 19:00 +0200
    Applied "ASoC: dwc: Use fifo depth to program FCR" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-04-07 20:00 +0200

csiph-web