Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1374270

Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified

From Arnaldo Carvalho de Melo <acme@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified
Date 2016-04-08 17:00 +0200
Message-ID <rlG39-5o2-39@gated-at.bofh.it> (permalink)
References <rlAK6-1xG-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Fri, Apr 08, 2016 at 11:14:09AM +0200, Thierry Reding escreveu:
> From: Thierry Reding <treding@nvidia.com>
> 
> The KBUILD_OUTPUT environment can be used to set the build directory as
> an alternative to passing the O variable on the command-line. This works
> with regular kernel builds, so it's surprising if it doesn't work within
> the tools/scripts directory.
> 
> Allow KBUILD_OUTPUT if O is not specified on the command-line to avoid
> any surprises.

I think this is fine, Jiri, Wang?

- Arnaldo
 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Arnaldo,
> 
> I'm not sure if you're the right person to send this to. There was noone
> reported by scripts/get_maintainer.pl, but it looks like you ended up
> applying most of the patches to this file lately, which kinda makes you
> the de facto maintainer =).
> 
> Thierry
> 
>  tools/scripts/Makefile.include | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
> index 8abbef164b4e..5467da41dc72 100644
> --- a/tools/scripts/Makefile.include
> +++ b/tools/scripts/Makefile.include
> @@ -8,6 +8,10 @@ ifeq ($(objtree),)
>  	objtree := $(O)
>  endif
>  endif
> +else
> +ifneq ($(KBUILD_OUTPUT),)
> +	OUTPUT := $(KBUILD_OUTPUT)/$(if $(subdir),$(subdir)/)
> +endif
>  endif
>  
>  # check that the output directory actually exists
> -- 
> 2.8.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified Thierry Reding <thierry.reding@gmail.com> - 2016-04-08 11:20 +0200
  Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-04-08 17:00 +0200
    Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified "Wangnan (F)" <wangnan0@huawei.com> - 2016-04-08 17:40 +0200
      Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-04-08 17:50 +0200

csiph-web