[QUEUED v20160408 06/18] stm class: Do not leak the chrdev in error path

From	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups	linux.kernel
Subject	[QUEUED v20160408 06/18] stm class: Do not leak the chrdev in error path
Date	2016-04-08 17:00 +0200
Message-ID	<rlG38-5o2-33@gated-at.bofh.it> (permalink)
References	<rlG37-5o2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Currently, the error path of stm_register_device() forgets to unregister
the chrdev. Fix this.

Reported-by: Alan Cox <alan.cox@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index 18f176eac0..e55ed67142 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -688,6 +688,8 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
 	return 0;
 
 err_device:
+	unregister_chrdev(stm->major, stm_data->name);
+
 	/* matches device_initialize() above */
 	put_device(&stm->dev);
 err_free:
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[QUEUED v20160408 06/18] stm class: Do not leak the chrdev in error path Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-04-08 17:00 +0200

csiph-web