Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374154

Re: [PATCH] mtd: nand: pasemi: switch to pr_* functions

Show all headers | View raw

On Fri, 2016-04-08 at 12:33 +0200, Rafał Miłecki wrote:
> This patch also replaces %08llx with %08zx for printing resource start
> address. Old format was triggering:
> warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’

trivia:

> diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
[]
> @@ -112,8 +112,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
>  	/* Allocate memory for MTD device structure and private data */
>  	chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
>  	if (!chip) {
> -		printk(KERN_WARNING
> -		       "Unable to allocate PASEMI NAND MTD device structure\n");
> +		pr_warn("Unable to allocate PASEMI NAND MTD device structure\n");

Maybe remove this unnecessary as there's an OOM stack dump.

>  		err = -ENOMEM;
>  		goto out;
>  	}
> @@ -163,13 +162,13 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
>  	}
>  
>  	if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
> -		printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
> +		pr_err("pasemi_nand: Unable to register MTD device\n");

Maybe remove the embedded "pasemi_nand: " and add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before the first #include?

>  		err = -ENODEV;
>  		goto out_lpc;
>  	}
>  
> -	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
> -	       res.start, lpcctl);
> +	pr_info("PA Semi NAND flash at %08zx, control at I/O %x\n", res.start,
> +		lpcctl);

Maybe use %pR, &res instead of res.start?

	pr_info("PA Semi NAND flash at %pR, control at I/O %x\n", &res, lpcctl);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: pasemi: switch to pr_* functions Rafał Miłecki <zajec5@gmail.com> - 2016-04-08 12:40 +0200
  Re: [PATCH] mtd: nand: pasemi: switch to pr_* functions Joe Perches <joe@perches.com> - 2016-04-08 13:00 +0200
  [PATCH V2] mtd: nand: pasemi: switch to pr_* functions Rafał Miłecki <zajec5@gmail.com> - 2016-04-08 13:20 +0200
    Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions Joe Perches <joe@perches.com> - 2016-04-08 19:00 +0200
    Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-09 12:00 +0200
      Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-13 09:50 +0200
    [PATCH V3] mtd: nand: pasemi: switch to dev_* printing functions Rafał Miłecki <zajec5@gmail.com> - 2016-04-13 11:50 +0200
      Re: [PATCH V3] mtd: nand: pasemi: switch to dev_* printing  functions Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-13 14:00 +0200

csiph-web