Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373059

Re: [PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel plug in

Show all headers | View raw

Sorry for disturb, I make a mistaken about the
receive list, please ignore this email.

- Yakir

On 04/07/2016 12:15 PM, Yakir Yang wrote:
> The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only
> send drm hp event when the irq_type and the enum value is true.
>
> if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...)
> 	drm_helper_hpd_irq_event(dp->drm_dev);
>
> So there would no drm hpd event when cable plug in, to fix that
> just need to assign all hotplug enum with no-zero values.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
> index f09275d..b456380 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
> @@ -127,10 +127,10 @@ enum analog_power_block {
>   };
>   
>   enum dp_irq_type {
> -	DP_IRQ_TYPE_HP_CABLE_IN,
> -	DP_IRQ_TYPE_HP_CABLE_OUT,
> -	DP_IRQ_TYPE_HP_CHANGE,
> -	DP_IRQ_TYPE_UNKNOWN,
> +	DP_IRQ_TYPE_HP_CABLE_IN  = BIT(0),
> +	DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1),
> +	DP_IRQ_TYPE_HP_CHANGE    = BIT(2),
> +	DP_IRQ_TYPE_UNKNOWN      = BIT(3),
>   };
>   
>   struct video_info {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel plug in Yakir Yang <ykk@rock-chips.com> - 2016-04-07 06:20 +0200
  Re: [PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel  plug in Yakir Yang <ykk@rock-chips.com> - 2016-04-07 06:20 +0200

csiph-web