Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372977

Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used

Show all headers | View raw

On Wed, Apr 06, 2016 at 03:27:20PM -0600, Al Stone wrote:
> On arm64 systems, using /dev/port does not really make sense; this is
> historically used for other architectures to access ISA IO ports, which
> with any luck do not exist on arm64 platforms.  With the following snippet
> of perl code (from Jeff Bastian <jbastian@redhat.com>), we can reliably
> panic an arm64 system with PCI enabled:
> 
> 	#!/usr/bin/perl -w
> 	# extracted from sensors-detect from lm_sensors
> 	# to reproduce kernel crash when probing the
> 	# Super-I/O ports
> 	use Fcntl qw(:DEFAULT :seek);
> 	sysopen(IOPORTS, "/dev/port", O_RDWR);
> 	binmode(IOPORTS);
> 	sysseek(IOPORTS, 0x2e, 0);
> 	syswrite(IOPORTS, pack("C", 0x0d), 1);
> 
> So, make sure CONFIG_DEVPORT cannot be set on arm64; it cannot really be
> used and it allows us to crash a kernel from user space.
> 
> Signed-off-by: Al Stone <ahs3@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/char/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index b272397..c532f62 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -587,7 +587,7 @@ config TELCLOCK
>  
>  config DEVPORT
>  	bool
> -	depends on !M68K
> +	depends on !M68K && !ARM64

Why not fix the real bug here, it's odd that only these two arches need
this disabled, don't you agree?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used Al Stone <ahs3@redhat.com> - 2016-04-06 23:30 +0200
  Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is  being used Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-07 02:20 +0200
    Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is  being used Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-07 09:30 +0200
      Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is  being used Al Stone <astone@redhat.com> - 2016-04-07 18:00 +0200
        Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used Arnd Bergmann <arnd@arndb.de> - 2016-04-09 04:30 +0200
        Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is  being used Jon Masters <jcm@jonmasters.org> - 2016-04-12 07:20 +0200

csiph-web