Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372972
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux |
| Date | 2016-04-07 02:10 +0200 |
| Message-ID | <rl5Gi-3Ao-25@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rb8cp-74T-5@gated-at.bofh.it> <rbiEO-5UZ-25@gated-at.bofh.it> <rkOFs-7Ky-5@gated-at.bofh.it> <rkS6l-1Kx-1@gated-at.bofh.it> <rkSSK-2lx-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register a mux and > unregister a device (that has been fixed), but is there anything else ? I don't remember anymore, that was a few thousand emails ago... But the suggestion about using devm_* shows that the original author has very little understanding about how the driver model works at all, which doesn't give me much hope at the moment... greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-06 08:00 +0200
Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-06 11:40 +0200
Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Felipe Balbi <balbi@kernel.org> - 2016-04-06 12:30 +0200
Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-07 02:10 +0200
Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Felipe Balbi <balbi@kernel.org> - 2016-04-07 07:10 +0200
csiph-web