Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372936
| From | Sören Brinkmann <soren.brinkmann@xilinx.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan |
| Date | 2016-04-07 01:10 +0200 |
| Message-ID | <rl4Ke-2Sw-19@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rkYls-6yQ-25@gated-at.bofh.it> <rkYv9-6Et-33@gated-at.bofh.it> <rkYv9-6Et-31@gated-at.bofh.it> <rl31L-1xP-1@gated-at.bofh.it> <rl3XQ-2ep-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2016-04-06 at 22:13:59 +0000, Koul, Vinod wrote:
> On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote:
> > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote:
> > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > > @@ -24,8 +24,8 @@ Optional properties:
> > > > > {3}, flush s2mm channel
> > > > >
> > > > > Required child node properties:
> > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel"
> > > > > or
> > > > > - "xlnx,axi-vdma-s2mm-channel".
> > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s-channel"
> > > > > or
> > > > > + "xlnx,axi-dma-s2mm-channel".
> > > >
> > > > This change is not backwards compatible and breaks every user of
> > > > the current
> > > > binding.
> > >
> > > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-
> > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa
> > > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of
> > > the above properties.
>
> That patch changes driver from vdma to dma. It does not change property
> name!
It does. Unfortunately there are no line numbers on that website, hence here an excerpt
from the commit you mention:
@@ -1220,26 +1220,26 @@ static int xilinx_vdma_chan_probe(struct xilinx_vdma_device *xdev,
if (!has_dre)
xdev->common.copy_align = fls(width - 1);
- if (of_device_is_compatible(node, "xlnx,axi-vdma-mm2s-channel")) {
+ if (of_device_is_compatible(node, "xlnx,axi-dma-mm2s-channel")) {
chan->direction = DMA_MEM_TO_DEV;
chan->id = 0;
Sören
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-04-06 18:20 +0200
RE: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-04-06 18:30 +0200
Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Lars-Peter Clausen <lars@metafoo.de> - 2016-04-06 23:20 +0200
Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan "Koul, Vinod" <vinod.koul@intel.com> - 2016-04-07 00:20 +0200
Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-04-07 01:10 +0200
Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan "Koul, Vinod" <vinod.koul@intel.com> - 2016-04-07 02:30 +0200
RE: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-04-07 06:10 +0200
Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-04-06 19:00 +0200
csiph-web