Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372800

Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

Show all headers | View raw

2016-04-06 8:55 GMT-07:00 Vivien Didelot <vivien.didelot@savoirfairelinux.com>:
> Neither the DSA layer nor the bridge code (see br_set_state) really care
> about eventual errors from STP state setters, so make it void.
>
> The DSA layer separates the prepare and commit phases of switchdev in
> two different functions. Logical errors must not happen in commit
> routines, so make them void.
>
> Changes v1 -> v2:
>   - rename port_stp_update to port_stp_state_set
>   - don't change code flow of bcm_sf2_sw_br_set_stp_state
>   - prefer netdev_err over netdev_warn
>
> Vivien Didelot (3):
>   net: dsa: make the STP state function return void
>   net: dsa: make the FDB add function return void
>   net: dsa: make the VLAN add function return void

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 18:00 +0200
  [PATCH net-next v2 1/3] net: dsa: make the STP state function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 18:00 +0200
  [PATCH net-next v2 3/3] net: dsa: make the VLAN add function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 18:00 +0200
  [PATCH net-next v2 2/3] net: dsa: make the FDB add function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 18:00 +0200
  Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and  FDB/VLAN add ops Andrew Lunn <andrew@lunn.ch> - 2016-04-06 18:30 +0200
  Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN  add ops Florian Fainelli <f.fainelli@gmail.com> - 2016-04-06 22:30 +0200
  Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and  FDB/VLAN add ops David Miller <davem@davemloft.net> - 2016-04-08 23:00 +0200

csiph-web