Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372831
| From | Lars-Peter Clausen <lars@metafoo.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode() |
| Date | 2016-04-06 23:10 +0200 |
| Message-ID | <rl2S7-1tt-41@gated-at.bofh.it> (permalink) |
| References | <rjaAr-7em-21@gated-at.bofh.it> <rkN6F-6Gq-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/06/2016 06:11 AM, Alison Schofield wrote:
> Replace the code that guarantees the device stays in direct mode with
> iio_device_{claim|release}_direct_mode() which does same.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> Changed in v2:
> - removed improper application of claim/release from intr handler
> - updated changelog
>
> drivers/staging/iio/adc/ad7606_core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606_core.c b/drivers/staging/iio/adc/ad7606_core.c
> index 6dbc811..f79ee61 100644
> --- a/drivers/staging/iio/adc/ad7606_core.c
> +++ b/drivers/staging/iio/adc/ad7606_core.c
> @@ -88,12 +88,12 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
>
> switch (m) {
> case IIO_CHAN_INFO_RAW:
> - mutex_lock(&indio_dev->mlock);
> - if (iio_buffer_enabled(indio_dev))
> - ret = -EBUSY;
> - else
> - ret = ad7606_scan_direct(indio_dev, chan->address);
> - mutex_unlock(&indio_dev->mlock);
> + ret = iio_device_claim_direct_mode(indio_dev);
> + if (ret)
> + return ret;
> +
> + ret = ad7606_scan_direct(indio_dev, chan->address);
> + iio_device_release_direct_mode(indio_dev);
>
> if (ret < 0)
> return ret;
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode() Alison Schofield <amsfield22@gmail.com> - 2016-04-06 06:20 +0200
Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode() Lars-Peter Clausen <lars@metafoo.de> - 2016-04-06 23:10 +0200
Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode() Jonathan Cameron <jic23@kernel.org> - 2016-04-10 16:00 +0200
csiph-web