Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372812

Re: [PATCH] Fixes some checkpatch.pl warnings

Show all headers | View raw

On Wed, Apr 06, 2016 at 04:38:07AM -0700, Manav Batra wrote:
> CHECK: Alignment should match open parenthesis
> WARNING: line over 80 characters
> 
> Signed-off-by: Manav Batra <batmanav10@gmail.com>
> ---
>  drivers/staging/rts5208/ms.c | 66 ++++++++++++++++++++++++++------------------
>  1 file changed, 39 insertions(+), 27 deletions(-)

Your subject is a bit "odd", please have it match the format that other
patches that have been accepted for this driver follows...

Also only do one thing per patch, you did multiple different things
here.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fixes some checkpatch.pl warnings Manav Batra <batmanav10@gmail.com> - 2016-04-06 13:40 +0200
  Re: [PATCH] Fixes some checkpatch.pl warnings Greg KH <gregkh@linuxfoundation.org> - 2016-04-06 23:00 +0200

csiph-web