Re: [PATCH] perf config: Fix build with older toolchain.

From	Taeung Song <treeze.taeung@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf config: Fix build with older toolchain.
Date	2016-04-05 15:50 +0200
Message-ID	<rkzwK-4pv-9@gated-at.bofh.it> (permalink)
References	<rkkR4-1n3-7@gated-at.bofh.it> <rkrIS-6Ag-13@gated-at.bofh.it> <rkzn4-4jC-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Arnaldo

On 04/05/2016 10:38 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Apr 05, 2016 at 02:24:19PM +0900, Taeung Song escreveu:
>> On 04/05/2016 07:07 AM, Vinson Lee wrote:
>>>   	if (!strcmp(var, "buildid.dir")) {
>>> -		const char *dirname = perf_config_dirname(var, value);
>>> +		const char *v = perf_config_dirname(var, value);
>>
>> Why you use 'v' variable name ?
>>
>> 'v' variable name was used in set_buildid_dir(), too.
>> But I send a patch renaming 'v' to 'home' because 'home' is more readable.
>> 37194f4 ("perf config: Rename 'v' to 'home' in set_buildid_dir()")
>> https://lkml.org/lkml/2016/3/27/98
>>
>> IMHO, I like using 'dir' instead of 'v'.
>
> Whatever, I'm switching this to 'dir', but don't pay _that_ much
> attention to variables that have such a narrow scope...
>

OK, I got it! :)

Thanks,
Taeung

Thread

[PATCH] perf config: Fix build with older toolchain. Vinson Lee <vlee@freedesktop.org> - 2016-04-05 00:10 +0200
  Re: [PATCH] perf config: Fix build with older toolchain. Taeung Song <taeung.dev@gmail.com> - 2016-04-05 07:30 +0200
    Re: [PATCH] perf config: Fix build with older toolchain. Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-05 15:40 +0200
      Re: [PATCH] perf config: Fix build with older toolchain. Taeung Song <treeze.taeung@gmail.com> - 2016-04-05 15:50 +0200
  Re: [PATCH] perf config: Fix build with older toolchain. Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-05 15:40 +0200
  [tip:perf/core] perf config: Fix build with older toolchain. tip-bot for Vinson Lee <tipbot@zytor.com> - 2016-04-13 09:20 +0200

csiph-web