Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1371344

Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call

From "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call
Date 2016-04-05 11:30 +0200
Message-ID <rkvt7-Vb-13@gated-at.bofh.it> (permalink)
References <rkaf0-1J2-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.

While you are at it, could you please also fix a similar instance
in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?

Thanks
Suzuki

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-04-04 12:50 +0200
  Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function  call Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-04 16:10 +0200
  Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function  call "Suzuki K. Poulose" <Suzuki.Poulose@arm.com> - 2016-04-05 11:30 +0200
    Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function  call Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-04-05 11:40 +0200

csiph-web