Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1371306

Re: [PATCH 0/3] power: Remove the deprecated extcon functions

From Chanwoo Choi <cwchoi00@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 0/3] power: Remove the deprecated extcon functions
Date 2016-04-05 10:10 +0200
Message-ID <rkudI-9L-17@gated-at.bofh.it> (permalink)
References <rhsi5-71J-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Ping.

Hi Sebastian,

Could you please review this patch-set?

Regards,
Chanwoo Choi


On Mon, Mar 28, 2016 at 8:25 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch-set removes the deprecated notifier API of extcon framework and
> then use the new extcon API[2] with the unique id[1] to indicate the each
> external connector. Alter deprecated API as following:
> - extcon_register_interest() -> extcon_register_notifier()
> - extcon_unregister_interest() -> extcon_unregister_notifier()
> - extcon_set_cable_state() -> extcon_set_cable_state_()
> - extcon_get_cable_state() -> extcon_get_cable_state_()
>
> And, extcon alters the name of USB charger connector in patch[3] as following:
> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */
> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */
> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */
>
> [1] Commit 2a9de9c0f08d61
> - ("extcon: Use the unique id for external connector instead of string)
> [2] Commit 046050f6e623e4
> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon
> [3] Commit 11eecf910bd81d
> - ("extcon: Modify the id and name of external connector")
>
> Chanwoo Choi (3):
>   power: charger-manager: Replace deprecatd API of extcon
>   power: axp288_charger: Replace deprecatd API of extcon
>   extcon: Remove the deprecated extcon functions
>
>  .../bindings/power_supply/charger-manager.txt      |   4 +-
>  drivers/extcon/extcon.c                            | 201 +++------------------
>  drivers/power/axp288_charger.c                     |  77 +++++---
>  drivers/power/charger-manager.c                    |  31 ++--
>  include/linux/extcon.h                             |  59 ------
>  include/linux/power/charger-manager.h              |   4 +-
>  6 files changed, 101 insertions(+), 275 deletions(-)
>
> --
> 1.9.1
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 0/3] power: Remove the deprecated extcon functions Chanwoo Choi <cwchoi00@gmail.com> - 2016-04-05 10:10 +0200

csiph-web