Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular

From	rcochran@linutronix.de
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular
Date	2016-04-05 06:40 +0200
Message-ID	<rkqWu-5Yd-7@gated-at.bofh.it> (permalink)
References	<rhmPn-39N-3@gated-at.bofh.it> <rkiPf-8d0-11@gated-at.bofh.it> <rkpH4-50J-7@gated-at.bofh.it> <rkqMN-5Tz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 05, 2016 at 04:20:47AM +0000, Brown, Len wrote:
> The first idle driver to register with cpuidle wins.
> 
> intel_idle should always get the opportunity
> to probe and register before acpi_idle (processor_idle.c)
> 
> When intel_idle was allowed to be modular,
> some distros build their kernel and loaded modules
> such that acpi_idle could probe first.  In such
> a kernel, intel_idle became dead code.
> 
> As intel_idle is a small driver, the q	uick fix
> was to make it Y/N so that it would always probe
> before acpi_idle, no matter how acpi_idle
> is build and loaded.
> 
> Yes, even though intel_idle is a tiny driver, I think
> it would be good to be able to unload it when it doesn't probe.

And that means fixing the race with acpi_idle, right?
 
> Today, it appears that acpi_idle (acpi/processor_idle.c)
> is compiled Y/N.

So it, too, needs work?

> No, I do not believe that cpuidle should bother
> supporting changing idle drivers at run-time.

Huh?  But you just said, "it would be good to be able to unload it
when it doesn't probe."

Thanks,
Richard

Thread

Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-04-04 22:00 +0200
  Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular rcochran@linutronix.de - 2016-04-05 05:20 +0200
    RE: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular "Brown, Len" <len.brown@intel.com> - 2016-04-05 06:30 +0200
      Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular rcochran@linutronix.de - 2016-04-05 06:40 +0200
        RE: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular "Brown, Len" <len.brown@intel.com> - 2016-04-05 08:00 +0200
          Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular rcochran@linutronix.de - 2016-04-05 09:40 +0200
            Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-07 19:00 +0200
    Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-04-05 20:30 +0200

csiph-web