Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

From	Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
Date	2016-04-05 05:10 +0200
Message-ID	<rkpxn-4WF-7@gated-at.bofh.it> (permalink)
References	<rkpe1-4vv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Please ignore, sorry for typos, and will resend.

On 2016/4/5 10:49, Kefeng Wang wrote:
> Commit cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate
> with new dw8250_check_lcr()") introduce a wrong logic when write val to
> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
> 
> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897("serial:
> 8250_dw: Use 64-bit access for OCTEON") for OCTEON, so for !PORT_OCTEON,
> we better to use coincident write func.
> 
> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
> Signe:-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/tty/serial/8250/8250_dw.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index a3fb95d..003ce60 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -103,16 +103,14 @@ static void dw8250_check_lcr(struct uart_port *p, int value)
>  
>  		dw8250_force_idle(p);
>  
> -#ifdef CONFIG_64BIT
> -		__raw_writeq(value & 0xff, offset);
> -#else
> -		if (p->iotype == UPIO_MEM32)
> +		if (IS_ENABLED(CONFIG_64BIT) && p->type == PORT_OCTEON)
> +			__raw_writeq(value & 0xff, offset);
> +		else if (p->iotype == UPIO_MEM32)
>  			writel(value, offset);
>  		else if (p->iotype == UPIO_MEM32BE)
>  			iowrite32be(value, offset);
>  		else
>  			writeb(value, offset);
> -#endif
>  	}
>  	/*
>  	 * FIXME: this deadlocks if port->lock is already held
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-05 04:50 +0200
  Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() kbuild test robot <lkp@intel.com> - 2016-04-05 05:00 +0200
  Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-05 05:10 +0200

csiph-web