Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory

From	Yakir Yang <ykk@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory
Date	2016-04-05 04:30 +0200
Message-ID	<rkoUG-4m4-3@gated-at.bofh.it> (permalink)
References	<r2pmb-aS-45@gated-at.bofh.it> <riv4e-2lN-15@gated-at.bofh.it> <riHyq-32C-21@gated-at.bofh.it> <riNku-7EN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/01/2016 12:02 AM, Doug Anderson wrote:
> Hi,
>
> On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding <treding@nvidia.com> wrote:
>> Ugh... most of these functions shouldn't be there in the first place. We
>> have helpers in the core that already do this. Most of the functionality
>> is duplicated in this driver.
>>
>> I realize that this is a problem that existed in the Exynos DP driver,
>> but somebody really ought to rewrite those parts to make use of the DRM
>> DP helpers.
> As I understand it from discussions in
> <http://article.gmane.org/gmane.linux.drivers.devicetree/162059> and
> <http://article.gmane.org/gmane.linux.kernel.samsung-soc/53048>, we
> shouldn't block merging the series but someone should pick up this
> work after the merge.
>
> So probably Yakir should fixup the problem pointed out by Guenter and
> send a new pull.
Yep, should I just update the pull request. Or I should send v15 first
and then update the pull request ?

- Yakir
> -Doug
>
>
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to  bridge directory Yakir Yang <ykk@rock-chips.com> - 2016-04-05 04:30 +0200

csiph-web