Re: [PATCH v2 5/5] LSM: LoadPin for kernel file loading restrictions

From	Mimi Zohar <zohar@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/5] LSM: LoadPin for kernel file loading restrictions
Date	2016-04-05 01:10 +0200
Message-ID	<rklN8-24A-31@gated-at.bofh.it> (permalink)
References	<rhMJQ-4ie-15@gated-at.bofh.it> <rhMJR-4ie-25@gated-at.bofh.it> <riSka-2AW-9@gated-at.bofh.it> <rkivU-86a-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-04-04 at 12:31 -0700, Kees Cook wrote:
> On Thu, Mar 31, 2016 at 2:24 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > On Mon, 2016-03-28 at 14:14 -0700, Kees Cook wrote:
> >
> >> +static const char *id_str[READING_MAX_ID] = {
> >> +     [READING_FIRMWARE] = "firmware",
> >> +     [READING_MODULE] = "kernel module",
> >> +     [READING_KEXEC_IMAGE] = "kexec image",
> >> +     [READING_KEXEC_INITRAMFS] = "kexec initramfs",
> >> +     [READING_POLICY] = "security policy",
> >> +};
> >> +

> I wonder if there should be a function that returns a const string for
> each kernel_read_file_id enum so users of the enum don't need to do
> it?

Right, having a single, corresponding, string array would be good.  Some
of the strings in id_str[] have blanks, which might be problematic for
the audit subsystem, and would need to be replaced with a hyphen or
underscore.

Mimi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 5/5] LSM: LoadPin for kernel file loading restrictions Kees Cook <keescook@chromium.org> - 2016-04-04 21:40 +0200
  Re: [PATCH v2 5/5] LSM: LoadPin for kernel file loading restrictions Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-04-05 01:10 +0200

csiph-web