Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370854
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c |
| Date | 2016-04-04 22:20 +0200 |
| Message-ID | <rkj8B-97-11@gated-at.bofh.it> (permalink) |
| References | <rfCEX-2qy-33@gated-at.bofh.it> <rfGSe-58C-21@gated-at.bofh.it> <rkj8B-97-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 04, 2016 at 01:15:45PM -0700, Ming Lin wrote:
> cleanup_sdb:
> for (i = 0; i < SG_MEMPOOL_NR; i++) {
> struct sg_pool *sgp = sg_pools + i;
> if (sgp->pool)
> mempool_destroy(sgp->pool);
> if (sgp->slab)
> kmem_cache_destroy(sgp->slab);
> }
>
> I'll keep the NULL check if no objection.
I don't necessarily, but given that this is a code move I'd prefer
to keep the code as similar as possible in the actual move patch..
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c Ming Lin <mlin@kernel.org> - 2016-04-04 22:20 +0200
Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c Christoph Hellwig <hch@lst.de> - 2016-04-04 22:20 +0200
Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c Ming Lin <mlin@kernel.org> - 2016-04-04 22:30 +0200
csiph-web