Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency model

From	Vojtech Pavlik <vojtech@suse.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency model
Date	2016-04-04 21:10 +0200
Message-ID	<rkhzQ-7r9-19@gated-at.bofh.it> (permalink)
References	<rgFKp-6zA-3@gated-at.bofh.it> <rgFKr-6zA-67@gated-at.bofh.it> <riKFX-5Dh-13@gated-at.bofh.it> <rkhqa-7no-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 04, 2016 at 01:21:38PM -0500, Josh Poimboeuf wrote:

> Hm, can you explain why it should be copied from the parent?
> 
> I'm thinking the above code is correct for today, but it should still be
> changed to be more future-proof.
> 
> Here's my thinking:
> 
> A forked task starts out with no stack, so if I understand correctly, it
> can safely start out in the goal universe, regardless of which universe
> its parent belongs to.
> 
> However, the current ret_from_fork code is a mess, and Andy Lutomirski
> has mentioned that he would like to give newly forked tasks a proper
> stack such that instead of jumping to ret_from_fork, they would just
> return from schedule().  In that case, it would no longer be safe to
> start the new task in the goal universe because it could be "sleeping"
> on a to-be-patched function.
> 
> So for proper future proofing, newly forked tasks should be started in
> the initial universe (rather than starting in the goal universe or
> inheriting the parent's universe).  They can then be transitioned over
> to the goal universe like any other task.  How does that sound?

How could a newly forked task start in the old universe if its parent
has already been migrated? Any context it inherits will already be from
the new universe.

-- 
Vojtech Pavlik
Director SuSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency  model Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-04 20:30 +0200
  Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency  model Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-04 20:40 +0200
    Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency  model Vojtech Pavlik <vojtech@suse.com> - 2016-04-05 13:40 +0200
      Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency  model Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-05 16:00 +0200
  Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency  model Vojtech Pavlik <vojtech@suse.com> - 2016-04-04 21:10 +0200

csiph-web