Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370627

Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration

Show all headers | View raw

On 04/04/2016 02:45 PM, Felipe Balbi wrote:
>
> Hi,
>
> Grygorii Strashko <grygorii.strashko@ti.com> writes:
>> The Keystone 2 supports DT-boot only, as result dma_mask will be
>> always configured properly from DT -
>> of_platform_device_create_pdata()->of_dma_configure(). More over,
>> dwc3-keystone.c can be built as module and in this case it's unsafe to
>> assign local variable as dma_mask.
>>
>> Hence, remove dma_mask configuration code.
>>
>> Cc: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> with these two patches from you, does USB Peripheral work on k2 devices ?

I've tried CONFIG_USB_DWC3_GADGET=y + g_zero and k2e was detected
as gzero dev from Host PC

>
> I'll drop my k2 changes from my series which I sent on saturday.
>

Yes, please.

-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc3: keystone: drop dma_mask configuration Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-04 13:40 +0200
  Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration Felipe Balbi <balbi@kernel.org> - 2016-04-04 13:50 +0200
    Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-04 15:50 +0200
      Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration Felipe Balbi <balbi@kernel.org> - 2016-04-05 07:30 +0200

csiph-web