Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1370595

Re: [PATCH] mm/huge_memory: replace VM_NO_THP VM_BUG_ON with actual VMA check

From Vlastimil Babka <vbabka@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] mm/huge_memory: replace VM_NO_THP VM_BUG_ON with actual VMA check
Date 2016-04-04 14:40 +0200
Message-ID <rkbXs-31q-21@gated-at.bofh.it> (permalink)
References <rjvOx-5Qg-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/02/2016 05:37 PM, Konstantin Khlebnikov wrote:
> Khugepaged detects own VMAs by checking vm_file and vm_ops but this
> way it cannot distinguish private /dev/zero mappings from other special
> mappings like /dev/hpet which has no vm_ops and popultes PTEs in mmap.
>
> This fixes false-positive VM_BUG_ON and prevents installing THP where
> they are not expected.
>
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Link: http://lkml.kernel.org/r/CACT4Y+ZmuZMV5CjSFOeXviwQdABAgT7T+StKfTqan9YDtgEi5g@mail.gmail.com
> Fixes: 78f11a255749 ("mm: thp: fix /dev/zero MAP_PRIVATE and vm_flags cleanups")
> Cc: stable <stable@vger.kernel.org>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] mm/huge_memory: replace VM_NO_THP VM_BUG_ON with actual  VMA check Vlastimil Babka <vbabka@suse.cz> - 2016-04-04 14:40 +0200

csiph-web