RE: [PATCH] staging: comedi: das1800: remove unused variable

From	Hartley Sweeten <HartleyS@visionengravers.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] staging: comedi: das1800: remove unused variable
Date	2016-04-06 18:40 +0200
Message-ID	<rkYEO-6IT-13@gated-at.bofh.it> (permalink)
References	<rkA9r-54V-3@gated-at.bofh.it> <rkKsa-4u3-1@gated-at.bofh.it> <rkSg2-1O6-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote:
> On 06/04/16 02:21, Hartley Sweeten wrote:
>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>> The variable unipolar was never used.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>> ---
>>>
>>> There may be a chance that reading from DAS1800_CONTROL_C is necessary
>>> before reading from DAS1800_STATUS. If that is true then please discard
>>> this patch.
>>
>> Actually the driver has a bug here.
>>
>> The analog input samples should  be munged if the inputs are configured for
>> bipolar mode.
>>
>> I have a series almost ready that cleans up this driver and fixes the bug.
>
> Hi Hartley, can the bug fix be placed at the top of your patch series? 

I'll split it out as a separate patch and post it shortly.

Thanks,
Hartley

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: das1800: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-05 16:30 +0200
  RE: [PATCH] staging: comedi: das1800: remove unused variable Hartley Sweeten <HartleyS@visionengravers.com> - 2016-04-06 03:30 +0200
    Re: [PATCH] staging: comedi: das1800: remove unused variable Ian Abbott <abbotti@mev.co.uk> - 2016-04-06 11:50 +0200
      Re: [PATCH] staging: comedi: das1800: remove unused variable Ian Abbott <abbotti@mev.co.uk> - 2016-04-06 12:50 +0200
        RE: [PATCH] staging: comedi: das1800: remove unused variable Hartley Sweeten <HartleyS@visionengravers.com> - 2016-04-06 20:20 +0200
      RE: [PATCH] staging: comedi: das1800: remove unused variable Hartley Sweeten <HartleyS@visionengravers.com> - 2016-04-06 18:40 +0200

csiph-web