Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372570

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> >>  	mutex_lock(&ps->smi_mutex);
>> >> -	ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state);
>> >> +	if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state))
>> >> +		netdev_warn(ds->ports[port], "cannot load address\n");
>> >
>> > In the SF2 driver you use pr_err, but here netdev_warn. We probably
>> > should be consistent if we error or warn. I would use netdev_error,
>> > since if this fails we probably have a real hardware problem.
>> 
>> I used pr_err in the SF2 driver to be consistent with the rest of the
>> code which only uses pr_err and pr_info.
>
> O.K, good.
>  
>> I was thinking about adding ds_err and ds_port_err to print errors for
>> ds->master_dev and ds->ports[port], but that might be overkill.
>
> I'm also trying to kill off the use of ds within the mv88e6xxx driver.
>
>> What do you think? Or local to the driver for the moment, like
>> mvsw_err maybe?
>
> I would keep it local. Also, for this sort of error, it does not need
> to differentiate on port. It is a hardware access error, something is
> wrong with the mdio bus/switch. So i would even put the message in the
> very low level reg_read/reg_write functions, and no where else.

OK, so I will keep a netdev_err() in _mv88e6xxx_port_fdb_add since I
don't like to ignore return values, and will send a future separate
patch to add such message in low level functions as you suggested, and
maybe voidify a few high level functions using them.

Thanks,
Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/3] net: dsa: make the FDB add function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-05 17:30 +0200
  Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return  void Andrew Lunn <andrew@lunn.ch> - 2016-04-06 02:00 +0200
    Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 05:20 +0200
      Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return  void Andrew Lunn <andrew@lunn.ch> - 2016-04-06 15:00 +0200
        Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-06 16:30 +0200

csiph-web