Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372446

[patch] ASoC: Intel: sst: fix a loop timeout in sst_hsw_stream_reset()

Show all headers | View raw

In the original code we ended the loop with tries set to -1 instead of
zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Not tested.

diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
index ac60f13..9156522 100644
--- a/sound/soc/intel/haswell/sst-haswell-ipc.c
+++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
@@ -1345,7 +1345,7 @@ int sst_hsw_stream_reset(struct sst_hsw *hsw, struct sst_hsw_stream *stream)
 		return 0;
 
 	/* wait for pause to complete before we reset the stream */
-	while (stream->running && tries--)
+	while (stream->running && --tries)
 		msleep(1);
 	if (!tries) {
 		dev_err(hsw->dev, "error: reset stream %d still running\n",

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] ASoC: Intel: sst: fix a loop timeout in  sst_hsw_stream_reset() Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-06 13:40 +0200
  Re: [alsa-devel] [patch] ASoC: Intel: sst: fix a loop timeout in  sst_hsw_stream_reset() Yang Jie <yang.jie@linux.intel.com> - 2016-04-07 03:20 +0200

csiph-web