Re: [PATCH v3 06/10] sysctl: drop away useless label

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 06/10] sysctl: drop away useless label
Date	Wed, 06 Apr 2016 13:40:02 +0200
Message-ID	<rkTYu-387-9@gated-at.bofh.it> (permalink)
References	<rkzGq-4wA-9@gated-at.bofh.it> <rkzGs-4wA-27@gated-at.bofh.it> <rkHuh-2lA-1@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="926601373"
Organization	Intel Finland Oy
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.18.5.1-1
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
X-Original-Cc	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>, Mimi Zohar <zohar@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-efi@vger.kernel.org, Matt Fleming <matt@codeblueprint.co.uk>, Arnd Bergmann <arnd@arndb.de>, Theodore Ts'o <tytso@mit.edu>
X-Original-Date	Wed, 06 Apr 2016 14:34:01 +0300
X-Original-Message-ID	<1459942441.17884.77.camel@linux.intel.com>
X-Original-References	<1459864579-55988-1-git-send-email-andriy.shevchenko@linux.intel.com> <1459864579-55988-7-git-send-email-andriy.shevchenko@linux.intel.com> <20160405151752.de82f221f1c70ff901b2b958@linux-foundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1372444

Show key headers only | View raw

On Tue, 2016-04-05 at 15:17 -0700, Andrew Morton wrote:
> On Tue,  5 Apr 2016 16:56:15 +0300 Andy Shevchenko <andriy.shevchenko@
> linux.intel.com> wrote:
> 
> > 
> > We have no locking in bin_uuid(). Thus, we may remove the out label
> > and use
> > return statements directly.
> > 

> Sure, but we may add locking or resource allocation in the future, in
> which case this change will need to be undone.  I think it's better to
> leave the code as-is.  It's presently quite typical kernel code.

I have noticed you updated the patch already. I'm fine with either. 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Thread

[PATCH v3 00/10] uuid: convert users to generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
  [PATCH v3 03/10] lib/uuid: move generate_random_uuid() to uuid.c Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
  [PATCH v3 06/10] sysctl: drop away useless label Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
    Re: [PATCH v3 06/10] sysctl: drop away useless label Andrew Morton <akpm@linux-foundation.org> - 2016-04-06 00:20 +0200
      Re: [PATCH v3 06/10] sysctl: drop away useless label Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-06 13:40 +0200
  [PATCH v3 08/10] efi: redefine type, constant, macro from generic code Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
  [PATCH v3 02/10] ima: use %pU to output UUID in printable format Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
    Re: [PATCH v3 02/10] ima: use %pU to output UUID in printable format Joe Perches <joe@perches.com> - 2016-04-06 01:20 +0200
      Re: [PATCH v3 02/10] ima: use %pU to output UUID in printable format Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-06 13:10 +0200
  [PATCH v3 09/10] efivars: use generic UUID library Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
  [PATCH v3 07/10] sysctl: use generic UUID library Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
  [PATCH v3 04/10] lib/uuid: introduce few more generic helpers for UUID Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:00 +0200
    Re: [PATCH v3 04/10] lib/uuid: introduce few more generic helpers  for UUID Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-05 16:20 +0200

csiph-web