Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372188
| From | Kedareswara rao Appana <appana.durga.rao@xilinx.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH v2 1/6] dmaengine: vdma: Fix checkpatch.pl warnings |
| Date | 2016-04-06 07:20 +0200 |
| Message-ID | <rkO2J-7uk-1@gated-at.bofh.it> (permalink) |
| References | <rkO2J-7uk-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This patch fixes the below checkpatch.pl warnings. WARNING: void function return statements are not generally useful + return; +} WARNING: void function return statements are not generally useful + return; +} WARNING: Missing a blank line after declarations + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Moritz Fischer <moritz.fischer@ettus.com> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> --- Changes for v2: ---> None. drivers/dma/xilinx/xilinx_vdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c index b873d98..3c5ce37 100644 --- a/drivers/dma/xilinx/xilinx_vdma.c +++ b/drivers/dma/xilinx/xilinx_vdma.c @@ -597,8 +597,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan *chan) chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR)); chan->err = true; } - - return; } /** @@ -623,8 +621,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan *chan) chan->err = true; } - - return; } /** @@ -874,6 +870,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void *data) * make sure not to write to other error bits to 1. */ u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR, errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK); -- 2.1.2
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[RESEND PATCH v2 1/6] dmaengine: vdma: Fix checkpatch.pl warnings Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-04-06 07:20 +0200 Re: [RESEND PATCH v2 1/6] dmaengine: vdma: Fix checkpatch.pl warnings Vinod Koul <vinod.koul@intel.com> - 2016-04-06 17:50 +0200
csiph-web