Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372064

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

Show all headers | View raw

On 2016-04-05 07:29 PM, David Miller wrote:
> From: Daniel Borkmann <daniel@iogearbox.net>
> Date: Tue, 05 Apr 2016 23:53:52 +0200
> 
>> On 04/05/2016 11:36 PM, Bastien Philbert wrote:
>>> This fixes error handling for the switch statement case
>>> SCTP_CMD_SEND_PKT by making the error value of the call
>>> to sctp_packet_transmit equal the variable error due to
>>> this function being able to fail with a error code. In
>>
>> What actual issue have you observed that you fix?
>>
>>> addition allow the call to sctp_ootb_pkt_free afterwards
>>> to free up the no longer in use sctp packet even if the
>>> call to the function sctp_packet_transmit fails in order
>>> to avoid a memory leak here for not freeing the sctp
>>
>> Not sure how this relates to your code?
> 
> Bastien, I'm seeing a clear negative pattern with the bug fixes
> you are submitting.
> 
> Just now you submitted the ICMP change which obviously was never
> tested because it tried to take the RTNL mutex in atomic context,
> and now this sctp thing.
> 
> If you don't start actually testing your changes and expalining
> clearly what the problem actually is, how you discovered it,
> and how you actually tested your patch, I will start completely
> ignoring your patch submissions.
> 
Ok sure I will be more careful with my future patches. Sorry about those 
two patches :(.
Bastien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-05 23:40 +0200
  Re: [PATCH] sctp: Fix error handling for switch statement case in the  function sctp_cmd_interprete Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-06 00:00 +0200
  Re: [PATCH] sctp: Fix error handling for switch statement case in  the function sctp_cmd_interprete Daniel Borkmann <daniel@iogearbox.net> - 2016-04-06 00:00 +0200
    Re: [PATCH] sctp: Fix error handling for switch statement case in  the function sctp_cmd_interprete David Miller <davem@davemloft.net> - 2016-04-06 01:30 +0200
      Re: [PATCH] sctp: Fix error handling for switch statement case in the  function sctp_cmd_interprete Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-06 01:40 +0200
  Re: [PATCH] sctp: Fix error handling for switch statement case in  the function sctp_cmd_interprete Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-04-06 00:20 +0200
    Re: [PATCH] sctp: Fix error handling for switch statement case in the  function sctp_cmd_interprete Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-06 01:10 +0200

csiph-web