Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1371926

Re: [PATCH] fs: return EPERM on immutable inode

From Dave Chinner <david@fromorbit.com>
Newsgroups linux.kernel
Subject Re: [PATCH] fs: return EPERM on immutable inode
Date 2016-04-05 22:50 +0200
Message-ID <rkG5c-1el-5@gated-at.bofh.it> (permalink)
References <rkzn4-4jC-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only
> a few places returning EACCES. And EPERM looks more reasonable to me.
> 
> So converting all EACCES to EPERM on immutable inode.
> 
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
> 
> I noticed this when running LTP on overlayfs, setxattr03 failed due to
> unexpected EACCES on immutable inode.

This should be in the commit message itself, rather than "EPERM
looks more reasonable".

Other than that, change seems fine to me.

Acked-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] fs: return EPERM on immutable inode Eryu Guan <guaneryu@gmail.com> - 2016-04-05 15:40 +0200
  Re: [PATCH] fs: return EPERM on immutable inode Dave Chinner <david@fromorbit.com> - 2016-04-05 22:50 +0200
  [PATCH v2] fs: return EPERM on immutable inode Eryu Guan <guaneryu@gmail.com> - 2016-04-06 05:50 +0200

csiph-web