Groups > linux.kernel > #1371918

RE: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client drivers.

From	Jake Oshins <jakeo@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client drivers.
Date	2016-04-05 22:30 +0200
Message-ID	<rkFLP-172-1@gated-at.bofh.it> (permalink)
References	<ds889-8u2-7@gated-at.bofh.it> <rjgw9-35I-5@gated-at.bofh.it> <rjgwa-35I-19@gated-at.bofh.it> <rkDAm-864-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 5, 2016 11:00 AM
> To: Jake Oshins <jakeo@microsoft.com>
> Cc: linux-pci@vger.kernel.org; gregkh@linuxfoundation.org; KY Srinivasan
> <kys@microsoft.com>; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; Haiyang Zhang <haiyangz@microsoft.com>; Hadden
> Hoppert <haddenh@microsoft.com>
> Subject: Re: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from
> client drivers.
> 
> Hi Jake,
> 
> On Fri, Apr 01, 2016 at 05:47:43PM -0700, Jake Oshins wrote:
> > This patch modifies all the callers of vmbus_mmio_allocate()
> > to call vmbus_mmio_free() instead of release_mem_region().
> 
> This changelog merely restates the C code.  Presumably there's some
> important difference between release_mem_region() and
> vmbus_mmio_free(), and we need a hint about what that is.
> 
> Oh, I see, there actually is no difference *yet*, but it's coming.
> I'd combine this with patch 2.  Then the patch is obviously correct
> all by itself, and the changelog for patch 2 makes clear what's
> happening.
> 
> In changelogs, don't bother with "this patch does" or "this function
> is introduced."  The context is obvious because the changelog is part
> of the commit.  Write imperative sentences, e.g., "Call
> vmbus_mmio_free() instead of release_mem_region()."
> 

Will do.  Thanks.

-- Jake Oshins

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client  drivers. Bjorn Helgaas <helgaas@kernel.org> - 2016-04-05 20:10 +0200
  RE: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client  drivers. KY Srinivasan <kys@microsoft.com> - 2016-04-05 20:30 +0200
  RE: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client  drivers. Jake Oshins <jakeo@microsoft.com> - 2016-04-05 22:30 +0200

csiph-web