Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371907
| From | Daniel Borkmann <daniel@iogearbox.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests |
| Date | 2016-04-05 21:40 +0200 |
| Message-ID | <rkEZs-vr-17@gated-at.bofh.it> (permalink) |
| References | <rkw5P-1sL-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/05/2016 12:02 PM, Naveen N. Rao wrote:
> JMP_JSET tests incorrectly used BPF_JNE. Fix the same.
>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> lib/test_bpf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index 27a7a26..e76fa4d 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -4303,7 +4303,7 @@ static struct bpf_test tests[] = {
> .u.insns_int = {
> BPF_ALU32_IMM(BPF_MOV, R0, 0),
> BPF_LD_IMM64(R1, 3),
> - BPF_JMP_IMM(BPF_JNE, R1, 2, 1),
> + BPF_JMP_IMM(BPF_JSET, R1, 2, 1),
> BPF_EXIT_INSN(),
> BPF_ALU32_IMM(BPF_MOV, R0, 1),
> BPF_EXIT_INSN(),
> @@ -4317,7 +4317,7 @@ static struct bpf_test tests[] = {
> .u.insns_int = {
> BPF_ALU32_IMM(BPF_MOV, R0, 0),
> BPF_LD_IMM64(R1, 3),
> - BPF_JMP_IMM(BPF_JNE, R1, 0xffffffff, 1),
> + BPF_JMP_IMM(BPF_JSET, R1, 0xffffffff, 1),
> BPF_EXIT_INSN(),
> BPF_ALU32_IMM(BPF_MOV, R0, 1),
> BPF_EXIT_INSN(),
> @@ -4474,7 +4474,7 @@ static struct bpf_test tests[] = {
> BPF_ALU32_IMM(BPF_MOV, R0, 0),
> BPF_LD_IMM64(R1, 3),
> BPF_LD_IMM64(R2, 2),
> - BPF_JMP_REG(BPF_JNE, R1, R2, 1),
> + BPF_JMP_REG(BPF_JSET, R1, R2, 1),
> BPF_EXIT_INSN(),
> BPF_ALU32_IMM(BPF_MOV, R0, 1),
> BPF_EXIT_INSN(),
> @@ -4489,7 +4489,7 @@ static struct bpf_test tests[] = {
> BPF_ALU32_IMM(BPF_MOV, R0, 0),
> BPF_LD_IMM64(R1, 3),
> BPF_LD_IMM64(R2, 0xffffffff),
> - BPF_JMP_REG(BPF_JNE, R1, R2, 1),
> + BPF_JMP_REG(BPF_JSET, R1, R2, 1),
> BPF_EXIT_INSN(),
> BPF_ALU32_IMM(BPF_MOV, R0, 1),
> BPF_EXIT_INSN(),
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-04-05 12:10 +0200 Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests Alexei Starovoitov <ast@fb.com> - 2016-04-05 18:00 +0200 Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests Daniel Borkmann <daniel@iogearbox.net> - 2016-04-05 21:40 +0200 Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests David Miller <davem@davemloft.net> - 2016-04-06 22:50 +0200
csiph-web