Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371848

Re: [RFC v2 3/7] Improve the tracking of active utilisation

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [RFC v2 3/7] Improve the tracking of active utilisation
Date 2016-04-05 20:10 +0200
Message-ID <rkDAm-864-9@gated-at.bofh.it> (permalink)
References <rj91E-6gd-5@gated-at.bofh.it> <rj9bl-6jH-31@gated-at.bofh.it> <rkAMb-5KI-29@gated-at.bofh.it> <rkDqG-7Lp-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 05, 2016 at 07:56:57PM +0200, luca abeni wrote:

> > > +		migrate_active = hrtimer_active(&p->dl.inactive_timer);
> > > +		if (migrate_active)
> > > +			sub_running_bw(&p->dl, &rq->dl);
> > > +		raw_spin_unlock(&rq->lock);
> > 
> > At this point task_rq() is still the above rq, so if the inactive timer
> > hits here it will lock this rq and subtract the running bw here _again_,
> > right?
> I think it will see the task state as TASK_RUNNING, so it will do nothing.
> Or it will cancelled later when the task is enqueued... I'll double check this.

Right, so this is select_task_rq_dl(), we run this in wakeups, before
TASK_RUNNING.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 17:10 +0200
  Re: [RFC v2 3/7] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-04-05 20:00 +0200
    Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 20:10 +0200
      Re: [RFC v2 3/7] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-04-05 21:30 +0200
        Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 21:40 +0200
        Re: [RFC v2 3/7] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-04-05 21:40 +0200
    Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 20:10 +0200
      Re: [RFC v2 3/7] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-04-05 21:40 +0200
    Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 20:20 +0200

csiph-web