Re: [RFC v2 3/7] Improve the tracking of active utilisation

From	luca abeni <luca.abeni@unitn.it>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 3/7] Improve the tracking of active utilisation
Date	2016-04-05 19:20 +0200
Message-ID	<rkCNX-7ui-9@gated-at.bofh.it> (permalink)
References	<rj91E-6gd-5@gated-at.bofh.it> <rj9bl-6jH-31@gated-at.bofh.it> <rkAsN-5ez-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 5 Apr 2016 16:48:03 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Apr 01, 2016 at 05:12:29PM +0200, Luca Abeni wrote:
> > +	/*
> > +	 * We cannot use inactive_task_timer() to invoke sub_running_bw()
> > +	 * at the 0-lag time, because the task could have been migrated
> > +	 * while SCHED_OTHER in the meanwhile.
> > +	 */
> > +	if (hrtimer_active(&p->dl.inactive_timer) &&
> > +		!hrtimer_callback_running(&p->dl.inactive_timer))
> >  		sub_running_bw(&p->dl, &rq->dl);
> 
> hrtimer_is_queued() ?

Uhm... I do not remember why I used this condition, but hrtimer_is_queued()
should be the right thing to be used, yes... I'll update the patch.



			Thanks,
				Luca

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 3/7] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-04-05 16:50 +0200
  Re: [RFC v2 3/7] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-04-05 19:20 +0200

csiph-web