Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370527
| From | Anna-Maria Gleixner <anna-maria@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] s390/cpum_sf: Remove superfluous SMP function call |
| Date | 2016-04-04 12:30 +0200 |
| Message-ID | <rk9VG-1Ap-53@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.
Replace smp_call_function_single() with a direct call of
setup_pmc_cpu(). To keep the calling convention, interrupts are
explicitely disabled around the call.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/s390/kernel/perf_cpum_sf.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--- a/arch/s390/kernel/perf_cpum_sf.c
+++ b/arch/s390/kernel/perf_cpum_sf.c
@@ -1510,7 +1510,6 @@ static void cpumf_measurement_alert(stru
static int cpumf_pmu_notifier(struct notifier_block *self,
unsigned long action, void *hcpu)
{
- unsigned int cpu = (long) hcpu;
int flags;
/* Ignore the notification if no events are scheduled on the PMU.
@@ -1523,11 +1522,15 @@ static int cpumf_pmu_notifier(struct not
case CPU_ONLINE:
case CPU_DOWN_FAILED:
flags = PMC_INIT;
- smp_call_function_single(cpu, setup_pmc_cpu, &flags, 1);
+ local_irq_disable();
+ setup_pmc_cpu(&flags);
+ local_irq_enable();
break;
case CPU_DOWN_PREPARE:
flags = PMC_RELEASE;
- smp_call_function_single(cpu, setup_pmc_cpu, &flags, 1);
+ local_irq_disable();
+ setup_pmc_cpu(&flags);
+ local_irq_enable();
break;
default:
break;
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] s390/cpum_sf: Remove superfluous SMP function call Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-04-04 12:30 +0200
Re: [PATCH] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-05 12:50 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de> - 2016-04-05 13:20 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-05 13:30 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-05 13:40 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-05 14:00 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call rcochran@linutronix.de - 2016-04-05 14:00 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de> - 2016-04-05 14:00 +0200
Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-05 14:20 +0200
Re: [PATCH] s390/cpum_sf: Remove superfluous SMP function call Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-04-05 14:20 +0200
[PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-04-05 18:00 +0200
Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-06 22:00 +0200
Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-04-07 17:20 +0200
Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-08 08:30 +0200
[PATCH v2] cpu/hotplug: fix rollback during error-out in __cpu_disable() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-04-08 14:50 +0200
csiph-web