Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370408
| From | LABBE Corentin <clabbe.montjoie@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] crypto: document correct return value for request allocation |
| Date | 2016-04-04 09:30 +0200 |
| Message-ID | <rk77s-86l-17@gated-at.bofh.it> (permalink) |
| References | <rjw7U-5Ym-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Apr 02, 2016 at 10:54:56AM -0500, Eric Biggers wrote:
> Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
> ---
> Documentation/DocBook/crypto-API.tmpl | 6 +++---
> include/crypto/aead.h | 3 +--
> include/crypto/hash.h | 3 +--
> include/crypto/skcipher.h | 3 +--
> include/linux/crypto.h | 3 +--
> 5 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/DocBook/crypto-API.tmpl b/Documentation/DocBook/crypto-API.tmpl
> index 348619f..d55dc5a 100644
> --- a/Documentation/DocBook/crypto-API.tmpl
> +++ b/Documentation/DocBook/crypto-API.tmpl
> @@ -1936,9 +1936,9 @@ static int test_skcipher(void)
> }
>
> req = skcipher_request_alloc(skcipher, GFP_KERNEL);
> - if (IS_ERR(req)) {
> - pr_info("could not allocate request queue\n");
> - ret = PTR_ERR(req);
> + if (!req) {
> + pr_info("could not allocate skcipher request\n");
> + ret = -ENOMEM;
> goto out;
> }
Hello
I think pr_err is better than pr_info.
Regards
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] crypto: document correct return value for request allocation Eric Biggers <ebiggers3@gmail.com> - 2016-04-02 18:00 +0200 Re: [PATCH] crypto: document correct return value for request allocation LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-04-04 09:30 +0200 Re: [PATCH] crypto: document correct return value for request allocation Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-15 16:40 +0200
csiph-web