Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370364
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey |
| Date | 2016-04-04 07:20 +0200 |
| Message-ID | <rk55G-6H0-47@gated-at.bofh.it> (permalink) |
| References | <rjqc9-1I3-3@gated-at.bofh.it> <rjqcb-1I3-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Apr 02, 2016 at 05:29:40PM +0800, Guodong Xu wrote:
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 41 ++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index c4f560a..28bc646 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -63,6 +63,47 @@
> status = "ok";
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + user_led4 {
Don't use underscores in node names: user-led4
> + label = "user_led4";
We need to make sure the node names and labels are aligned with other
boards. There's some discussion about this for the new db600 board.
This looks closer to what we should have than what we have for
db410c currently.
Rob
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/16] DTS for hi6220 and HiKey Guodong Xu <guodong.xu@linaro.org> - 2016-04-02 11:40 +0200
[PATCH v2 09/16] arm64: dts: add hi6220 usb node Guodong Xu <guodong.xu@linaro.org> - 2016-04-02 11:40 +0200
[PATCH v2 01/16] arm64: dts: Reserve memory regions for hi6220 Guodong Xu <guodong.xu@linaro.org> - 2016-04-02 11:40 +0200
[PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey Guodong Xu <guodong.xu@linaro.org> - 2016-04-02 11:40 +0200
Re: [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey Rob Herring <robh@kernel.org> - 2016-04-04 07:20 +0200
[PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-02 11:40 +0200
Re: [PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes Rob Herring <robh@kernel.org> - 2016-04-04 07:20 +0200
Re: [PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes Guodong Xu <guodong.xu@linaro.org> - 2016-04-12 11:50 +0200
csiph-web