[tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Sedat Dilek <sedat.dilek@gmail.com>
Newsgroups	linux.kernel
Subject	[tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s
Date	Sat, 02 Apr 2016 08:00:01 +0200
Message-ID	<rjmLf-7Gb-1@gated-at.bofh.it> (permalink)
X-Original-To	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:date:message-id:subject:from:to:cc; bh=pE+ZCwl2r3AqApSUwjkvJin6DNU5uwpdjo0MMeOU6GU=; b=ar6uoL9dO3S7Iuq1At5h7XJKyaidRUNWP4AUyFGraRBkFCATeb8IPsQM3YPrraDL16 2wuftStqtXWljrzC4MXivGbMMTWBhMudfN+CZ/knNmVyZ73tUGWDpVAIcsyfsCM1kEvh PqRF7Z0ryGFWJ2MjAXLcXEGdfrX3ZKiBOMa8pt9qt8KOHdH6ArmrZVDCwS0a/cmbaL1q Q/eGZzFVlLhY8ZKAeDC2aSZqGMNy/eE9Z1eiMXI1gfPxdEQJqvSye6qwLq263yYYTRrI /CmlpHq2F3GplJgz4cTLulnhEIVsSjMqrR+lmCWWOg99mzrl8TrsLVPZr8gNld1QJvQF kaiQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:date:message-id:subject :from:to:cc; bh=pE+ZCwl2r3AqApSUwjkvJin6DNU5uwpdjo0MMeOU6GU=; b=ikeZ/oodekSJfGNb3CmyQB1bnxjsBGsVak+b4hA6/L0Q/ldRb8Xf6UuJgs8JVHXkT0 KoYVA4zjROdm6tID/X4e8jiQoptnEraRs5fEnMFKzJ5/xlNPuEHRc8PFCNwUJajiAbT7 gv0Z7JEvS4dkvKixVjZLLSKVizl2u3nOd7JPI/IGEWWhC1MJ6E1Vu0BH30wHf7f+Hwxv AOn+xfJS2fB72unda4b1wqadHP6xBV3ktrqQgofu8+dI7s9tIn5HPijqd8rH2Sw/1gnc KAMl7aKLqWh5F+PTC9Oy2PF+axi2dSNDPYJ7Cd53TnTNMpjbClJjgZ9mSFUjirjr3h61 JPaw==
X-Gm-Message-State	AD7BkJJvfX+wVXr0r3YZUhBH2TpDCPYn+pvC2WHspvPKkkFu6i8IbxfKEMMlxnx8d6zeDtnTFH1pbtt01u70fw==
MIME-Version	1.0
X-Received	by 10.31.54.75 with SMTP id d72mr4819854vka.30.1459576218660; Fri, 01 Apr 2016 22:50:18 -0700 (PDT)
Reply-To	sedat.dilek@gmail.com
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	Ingo Molnar <mingo@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>, "the arch/x86 maintainers" <x86@kernel.org>
X-Original-Date	Sat, 2 Apr 2016 07:50:18 +0200
X-Original-Message-ID	<CA+icZUVivXZ4U8Gdnhk1Hi6bwhvv7Hw7NCr_KQmE4sLW2XFLRw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1369873

Show key headers only | View raw

Hi,

I was looking through tip Git tree...

Why didn't you use...

+ IS_ENABLED(CONFIG_DEBUG_PAGEALLOC) ? " DEBUG_PAGEALLOC" : "",

...instead of...

+ debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "",

...for consistency reasons?

Regards,
- Sedat -

[1] http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/debug&id=8fad7ec51e1b9e262e0bdd34e800ac1ea5e84dec

P.S.: From [1] "x86/dumpstack: Combine some printk()s"

--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -260,19 +260,12 @@ int __die(const char *str, struct pt_regs *regs, long err)
unsigned long sp;
#endif
printk(KERN_DEFAULT
- "%s: %04lx [#%d] ", str, err & 0xffff, ++die_counter);
-#ifdef CONFIG_PREEMPT
- printk("PREEMPT ");
-#endif
-#ifdef CONFIG_SMP
- printk("SMP ");
-#endif
- if (debug_pagealloc_enabled())
- printk("DEBUG_PAGEALLOC ");
-#ifdef CONFIG_KASAN
- printk("KASAN");
-#endif
- printk("\n");
+ "%s: %04lx [#%d]%s%s%s%s\n", str, err & 0xffff, ++die_counter,
+ IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : "",
+ IS_ENABLED(CONFIG_SMP) ? " SMP" : "",
+ debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "",
+ IS_ENABLED(CONFIG_KASAN) ? " KASAN" : "");
+
if (notify_die(DIE_OOPS, str, regs, err,
current->thread.trap_nr, SIGSEGV) == NOTIFY_STOP)
return 1;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s Sedat Dilek <sedat.dilek@gmail.com> - 2016-04-02 08:00 +0200
  Re: [tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s Thomas Gleixner <tglx@linutronix.de> - 2016-04-02 13:20 +0200
    Re: [tip.git#x86/debug] Re: x86/dumpstack: Combine some printk()s Sedat Dilek <sedat.dilek@gmail.com> - 2016-04-04 17:40 +0200

csiph-web