Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths

From	Steve Muckle <steve.muckle@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths
Date	2016-04-01 23:50 +0200
Message-ID	<rjf74-1Sx-5@gated-at.bofh.it> (permalink)
References	<rglVo-Lh-11@gated-at.bofh.it> <riFPZ-20X-47@gated-at.bofh.it> <riGVI-2I1-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/31/2016 02:14 AM, Peter Zijlstra wrote:
> On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote:
>>> > >  - passing an argument into attach_entity_load_avg() to indicate                                                 
>>> > >    whether calling the cpufreq hook is necessary
>>> > > 
>>> > > Both of these are ugly in their own way but would avoid a runtime
>>> > > cost. Opinions welcome.
>> > 
>> > Lemme see what this would look like while I throw the below into the bit
>> > bucket.
> OK, so the below looks a lot more sane; and has the surprising benefit
> of actually shrinking the text size..
> 
>   43675    1226      24   44925    af7d defconfig-build/kernel/sched/fair.o.base
>   43723    1226      24   44973    afad defconfig-build/kernel/sched/fair.o.patch
>   43595    1226      24   44845    af2d defconfig-build/kernel/sched/fair.o.patch+
> 
> ---
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c

Cool, thanks. Shall I fold this into this patch and resend the series of
3? Or would you prefer to add this change separately?

thanks,
Steve

Thread

[RFC PATCH] sched/fair: call cpufreq hook in additional paths Steve Muckle <steve.muckle@linaro.org> - 2016-03-24 23:30 +0100
  Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths Peter Zijlstra <peterz@infradead.org> - 2016-03-31 10:10 +0200
    Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths Peter Zijlstra <peterz@infradead.org> - 2016-03-31 11:20 +0200
      Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-31 14:00 +0200
      Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths Steve Muckle <steve.muckle@linaro.org> - 2016-04-01 23:50 +0200
        Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths Peter Zijlstra <peterz@infradead.org> - 2016-04-02 00:00 +0200

csiph-web