Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY
Date	2016-04-01 21:50 +0200
Message-ID	<rjdeW-DG-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <rdwWZ-1LR-1@gated-at.bofh.it> <rj79w-4RA-15@gated-at.bofh.it> <rj8yB-5ND-3@gated-at.bofh.it> <rj9O1-6S2-1@gated-at.bofh.it> <rja7p-70D-39@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

On 04/01/2016 07:19 PM, Bin Liu wrote:

>>>>> +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode);
>>>>
>>>> Don't prefer export symbols from PHY driver. That'll create unnecessary
>>>> dependencies between the controller and the PHY.
>>>
>>> Agreed.
>>>
>>>>
>>>> I think it'll be better to create a new attribute and use it?
>>>
>>> Another simpler option is to not support _set_mode() for DA8xx, and the
>>> phy driver set the otgmode bit in probe() based on dr_mode of the
>>> controller.
>>>
>>> Regards,
>>> -Bin.
>>>
>>
>> This certainly works for my particular use case, however, Sergei
>> Shtylyov, who wrote the da8xx musb glue layer originally, seemed to
>> recall in his review of the patch series that this really is
>> necessary for OTG mode to work properly.
>
> I don't know much about the usb module on DA8xx, but it seems to me that
> _set_mode() has nothing to do with OTG mode.

    No, it does.

> musb_core only calls
> _set_mode() in two places - 1) sysfs: musb_mode_store(), 2) init:
> musb_init_controller(). None of them should be related to OTG mode.

    Both these places do select OTG mode.

> Regards,
> -Bin.

MBR, Sergei

Thread

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2016-04-01 15:20 +0200
  Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Bin Liu <b-liu@ti.com> - 2016-04-01 16:50 +0200
    Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY David Lechner <david@lechnology.com> - 2016-04-01 18:10 +0200
      Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Bin Liu <b-liu@ti.com> - 2016-04-01 18:30 +0200
        Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-01 21:50 +0200
      Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-01 21:50 +0200
        Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Bin Liu <b-liu@ti.com> - 2016-04-01 22:00 +0200
  Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY David Lechner <david@lechnology.com> - 2016-04-13 23:00 +0200
    Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2016-04-14 14:40 +0200

csiph-web